fix: Settings crash, photo preview before sending, incoming-content hardening

Settings crashed with a TypeError: the profile card passed a SepotFingerprint object where the localized string formatter expects a String (hidden behind a `dynamic` parameter). Also fixes RangeError in avatar initials (empty names, double spaces) and switches initials to grapheme clusters so emoji don't get split. New photo preview screen: a captured or picked photo no longer sends immediately — it opens in a preview with freehand drawing (7 colours, undo), draggable text overlay, 90° rotation and a caption field. Nothing leaves the device until Send is tapped. Incoming-content hardening: decryption and content processing are now separated in the delivery path. Once an envelope is decrypted the ratchet has advanced, so redelivery can never help — permanently malformed content (FormatException/TypeError) is acked and dropped instead of poisoning the queue on every reconnect. Attachment metadata now validates base64 of the crypto fields up front, and a corrupt inline thumbnail no longer breaks bubble rendering. PNG without real transparency (screenshots, edited photos) is now re-encoded as JPEG — several times smaller on the wire. Tests: 116 (new widget tests for Settings and the photo preview, AttachmentMeta wire validation).
2026-07-13 08:15:01 +02:00
parent a60aaca326
commit 641d70b76e
24 changed files with 1299 additions and 41 deletions
@@ -0,0 +1,121 @@
+import 'dart:typed_data';
+
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:image/image.dart' as img;
+import 'package:sepot/features/conversation/photo_preview_screen.dart';
+import 'package:sepot/l10n/generated/app_localizations.dart';
+
+/// Náhled fotky před odesláním: nic neodchází bez potvrzení, úpravy
+/// (rotace) se propíšou do odeslaných bajtů, popisek do výsledku.
+///
+/// Dekódování obrázku a render úprav jsou reálné async operace engine,
+/// proto testy běží v `tester.runAsync`.
+Uint8List _testPng({int width = 8, int height = 4}) =>
+    Uint8List.fromList(img.encodePng(img.Image(width: width, height: height)));
+
+void main() {
+  Future<Future<PhotoPreviewResult?>> openPreview(
+    WidgetTester tester,
+    Uint8List bytes,
+  ) async {
+    late Future<PhotoPreviewResult?> pushed;
+    await tester.pumpWidget(
+      MaterialApp(
+        locale: const Locale('cs'),
+        localizationsDelegates: AppLocalizations.localizationsDelegates,
+        supportedLocales: AppLocalizations.supportedLocales,
+        home: Builder(
+          builder: (context) => ElevatedButton(
+            onPressed: () {
+              pushed = Navigator.of(context).push<PhotoPreviewResult>(
+                MaterialPageRoute(
+                  builder: (_) => PhotoPreviewScreen(
+                    bytes: bytes,
+                    fileName: 'test.png',
+                    mime: 'image/png',
+                  ),
+                ),
+              );
+            },
+            child: const Text('otevřít'),
+          ),
+        ),
+      ),
+    );
+    await tester.tap(find.text('otevřít'));
+    await tester.pump();
+    await tester.pump(const Duration(milliseconds: 400));
+    // Reálný async decode obrázku — počkat, až zmizí spinner.
+    for (var i = 0; i < 50; i++) {
+      await Future<void>.delayed(const Duration(milliseconds: 20));
+      await tester.pump();
+      if (find.byType(CircularProgressIndicator).evaluate().isEmpty) break;
+    }
+    expect(
+      find.byType(CircularProgressIndicator),
+      findsNothing,
+      reason: 'obrázek se nedekódoval',
+    );
+    return pushed;
+  }
+
+  Future<PhotoPreviewResult?> settleResult(
+    WidgetTester tester,
+    Future<PhotoPreviewResult?> pushed,
+  ) async {
+    // Render + pop jsou reálné async operace — pumpovat, dokud route žije.
+    // pump s duration posouvá i pop animaci, jinak by route nikdy nezmizel.
+    for (var i = 0; i < 100; i++) {
+      await Future<void>.delayed(const Duration(milliseconds: 20));
+      await tester.pump(const Duration(milliseconds: 50));
+      if (find.byType(PhotoPreviewScreen).evaluate().isEmpty) break;
+    }
+    return pushed;
+  }
+
+  testWidgets('zrušení nic nepošle', (tester) async {
+    await tester.runAsync(() async {
+      final pushed = await openPreview(tester, _testPng());
+      await tester.tap(find.byIcon(Icons.close));
+      final result = await settleResult(tester, pushed);
+      expect(find.byType(PhotoPreviewScreen), findsNothing);
+      expect(result, isNull);
+    });
+  });
+
+  testWidgets('odeslání bez úprav vrací původní bajty + popisek', (
+    tester,
+  ) async {
+    await tester.runAsync(() async {
+      final bytes = _testPng();
+      final pushed = await openPreview(tester, bytes);
+
+      await tester.enterText(find.byType(TextField), 'ahoj z testu');
+      await tester.tap(find.byTooltip('Poslat'));
+      final result = await settleResult(tester, pushed);
+
+      expect(result, isNotNull);
+      expect(result!.bytes, same(bytes)); // beze změn = žádný re-encode tady
+      expect(result.caption, 'ahoj z testu');
+      expect(result.fileName, 'test.png');
+    });
+  });
+
+  testWidgets('rotace se propíše do odeslaných bajtů', (tester) async {
+    await tester.runAsync(() async {
+      final pushed = await openPreview(tester, _testPng(width: 8, height: 4));
+
+      await tester.tap(find.byTooltip('Otočit'));
+      await tester.pump();
+      await tester.tap(find.byTooltip('Poslat'));
+      final result = await settleResult(tester, pushed);
+
+      expect(result, isNotNull);
+      final decoded = img.decodeImage(result!.bytes)!;
+      expect(decoded.width, 4); // 8×4 otočeno o 90° → 4×8
+      expect(decoded.height, 8);
+      expect(result.caption, isNull);
+    });
+  });
+}
@@ -0,0 +1,59 @@
+import 'dart:typed_data';
+
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:sepot/features/settings/settings_screen.dart';
+import 'package:sepot/l10n/generated/app_localizations.dart';
+import 'package:sepot/models/identity.dart';
+import 'package:sepot/providers/identity_provider.dart';
+
+/// Obrazovka Nastavení se musí vykreslit bez výjimky v build —
+/// pád tady znamená pro uživatele „Tahle obrazovka se nevykreslila".
+class _FakeIdentityNotifier extends IdentityNotifier {
+  _FakeIdentityNotifier(this._identity);
+  final LocalIdentity? _identity;
+
+  @override
+  Future<LocalIdentity?> build() async => _identity;
+}
+
+LocalIdentity _identityWithName(String name) => LocalIdentity(
+      displayName: name,
+      identityPrivateKey: Uint8List(32),
+      identityPublicKey: Uint8List(33),
+      createdAt: DateTime.utc(2026, 1, 1),
+    );
+
+Widget _app(LocalIdentity? identity) => ProviderScope(
+      overrides: [
+        identityProvider.overrideWith(() => _FakeIdentityNotifier(identity)),
+      ],
+      child: MaterialApp(
+        locale: const Locale('cs'),
+        localizationsDelegates: AppLocalizations.localizationsDelegates,
+        supportedLocales: AppLocalizations.supportedLocales,
+        home: const SettingsScreen(),
+      ),
+    );
+
+void main() {
+  testWidgets('vykreslí se s běžnou identitou', (tester) async {
+    await tester.pumpWidget(_app(_identityWithName('Alice')));
+    await tester.pump();
+    expect(tester.takeException(), isNull);
+    expect(find.text('Alice'), findsOneWidget);
+  });
+
+  testWidgets('vykreslí se s prázdným jménem identity', (tester) async {
+    await tester.pumpWidget(_app(_identityWithName('')));
+    await tester.pump();
+    expect(tester.takeException(), isNull);
+  });
+
+  testWidgets('vykreslí se bez identity', (tester) async {
+    await tester.pumpWidget(_app(null));
+    await tester.pump();
+    expect(tester.takeException(), isNull);
+  });
+}