fix: Settings crash, photo preview before sending, incoming-content hardening

Settings crashed with a TypeError: the profile card passed a SepotFingerprint object where the localized string formatter expects a String (hidden behind a `dynamic` parameter). Also fixes RangeError in avatar initials (empty names, double spaces) and switches initials to grapheme clusters so emoji don't get split. New photo preview screen: a captured or picked photo no longer sends immediately — it opens in a preview with freehand drawing (7 colours, undo), draggable text overlay, 90° rotation and a caption field. Nothing leaves the device until Send is tapped. Incoming-content hardening: decryption and content processing are now separated in the delivery path. Once an envelope is decrypted the ratchet has advanced, so redelivery can never help — permanently malformed content (FormatException/TypeError) is acked and dropped instead of poisoning the queue on every reconnect. Attachment metadata now validates base64 of the crypto fields up front, and a corrupt inline thumbnail no longer breaks bubble rendering. PNG without real transparency (screenshots, edited photos) is now re-encoded as JPEG — several times smaller on the wire. Tests: 116 (new widget tests for Settings and the photo preview, AttachmentMeta wire validation).
2026-07-13 08:15:01 +02:00
parent a60aaca326
commit 641d70b76e
24 changed files with 1299 additions and 41 deletions
@@ -0,0 +1,60 @@
+import 'dart:convert';
+
+import 'package:flutter_test/flutter_test.dart';
+import 'package:sepot/models/attachment.dart';
+
+/// Validace metadat přílohy z drátu — remote input od protistrany.
+/// Vadný náhled nesmí shodit render bubliny, vadná krypto pole musí
+/// zprávu zabít už při příjmu (ACK + zahodit), ne až při použití.
+void main() {
+  Map<String, dynamic> validWire() => {
+        'bid': 'a1b2c3d4e5f60718293a4b5c6d7e8f90',
+        'k': base64Encode(List.filled(32, 1)),
+        'n': base64Encode(List.filled(12, 2)),
+        'd': base64Encode(List.filled(32, 3)),
+        's': 1024,
+        'mime': 'image/jpeg',
+      };
+
+  test('validní wire projde a thumbnail dekóduje', () {
+    final meta = AttachmentMeta.fromWire(
+        {...validWire(), 'th': base64Encode([1, 2, 3])});
+    expect(meta.thumbnail, [1, 2, 3]);
+    expect(meta.key.length, 32);
+  });
+
+  test('vadný base64 náhled se zahodí, zpráva žije', () {
+    final meta = AttachmentMeta.fromWire({...validWire(), 'th': '@@@!!'});
+    expect(meta.thumbB64, isNull);
+    expect(meta.thumbnail, isNull);
+    expect(meta.blobId, validWire()['bid']);
+  });
+
+  test('vadná base64 krypto pole zprávu zabijí FormatException', () {
+    for (final field in ['k', 'n', 'd']) {
+      expect(
+        () => AttachmentMeta.fromWire({...validWire(), field: 'ne base64!'}),
+        throwsFormatException,
+        reason: 'pole $field s nevalidní base64 musí hodit',
+      );
+    }
+  });
+
+  test('nesmyslná velikost hodí FormatException', () {
+    expect(
+      () => AttachmentMeta.fromWire({...validWire(), 's': 0}),
+      throwsFormatException,
+    );
+    expect(
+      () => AttachmentMeta.fromWire({...validWire(), 's': 600 * 1024 * 1024}),
+      throwsFormatException,
+    );
+  });
+
+  test('špatný typ pole hodí TypeError (poison cesta ACKuje)', () {
+    expect(
+      () => AttachmentMeta.fromWire({...validWire(), 'k': 42}),
+      throwsA(isA<TypeError>()),
+    );
+  });
+}